Conversation
maayan25
reviewed
Apr 9, 2026
Collaborator
maayan25
left a comment
maayan25
left a comment
There was a problem hiding this comment.
Thanks @Aldrich-Fernandes !! Do we still need the config file for names? Is this a residual from the old implementation of Receptionist?
Collaborator
Author
|
I believe this version for the receptionist still uses the names and drinks from the config. However, I can double check and update relevant files such as the get_name_and_drink for the HRI task to not use the predetermined list. |
Collaborator
|
That's ok, as long as the HRI doesn't use it |
maayan25
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished porting receptionist's get states (#379)